Switch to runtime configuration YAML #608

tomkerkhove · 2019-07-07T16:10:47Z

Switch to runtime configuration YAML.

A follow-up PR will update Helm Chart.

Relates to #431

Configuration sample

server:
  httpPort: 88
prometheus:
  scrapeEndpoint:
    baseUriPath: /scrape
metricsConfiguration:
  absolutePath: /config/metrics-declaration.yaml
telemetry:
  applicationInsights:
    instrumentationKey: ABC
    isEnabled: true
  containerLogs:
    isEnabled: true
    verbosity: trace
  defaultVerbosity: warning
featureFlags:
  disableMetricTimestamps: true # false by default

Done via new PR

Update documentation
Ensure optional variables are working fine

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

promitor-bot · 2019-07-07T16:14:13Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr608

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr608 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr608

You can find a CI version of our Helm chart on hub.helm.sh

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

…kerkhove/promitor into features-runtime-config-yaml

promitor-bot · 2019-07-07T16:47:30Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr608

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr608 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr608

You can find a CI version of our Helm chart on hub.helm.sh

promitor-bot · 2019-07-08T15:50:49Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr608

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr608 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr608

You can find a CI version of our Helm chart on hub.helm.sh

promitor-bot · 2019-07-09T12:44:41Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr608

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr608 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr608

You can find a CI version of our Helm chart on hub.helm.sh

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

promitor-bot · 2019-07-19T16:41:44Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr608

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr608 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr608

You can find a CI version of our Helm chart on hub.helm.sh

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

promitor-bot · 2019-07-22T17:51:23Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr608

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr608 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr608

You can find a CI version of our Helm chart on hub.helm.sh

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

promitor-bot · 2019-07-22T19:17:02Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr608

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr608 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr608

You can find a CI version of our Helm chart on hub.helm.sh

promitor-bot · 2019-07-25T18:23:26Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr608

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr608 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr608

You can find a CI version of our Helm chart on hub.helm.sh

promitor-bot · 2019-07-25T18:37:02Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr608

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr608 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr608

You can find a CI version of our Helm chart on hub.helm.sh

promitor-bot · 2019-07-25T18:49:52Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr608

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr608 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr608

You can find a CI version of our Helm chart on hub.helm.sh

tomkerkhove added 8 commits July 1, 2019 12:52

Provide foundation for config via YAML

31812c1

ENV over YAML

205b046

Provide environment variables with prefix as well

053b53b

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

WIP

b029c95

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

WIP

8bf8106

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Improve defaults

d485c88

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Simplify

20ce005

Break all the things

304e733

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

tomkerkhove added 21 commits July 7, 2019 18:22

Improve code quality

484d632

Clean-up Dockerfile

599ef5b

Remove temporary variable

503a621

Code quality fixes

3027a9c

Re-enable runtime validation

0f34cc9

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Code quality

0d2b906

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Provide foundation for config via YAML

c3e399c

ENV over YAML

7390f82

Provide environment variables with prefix as well

63c9f9b

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

WIP

31face6

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

WIP

8a8d91e

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Improve defaults

ee62049

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Simplify

311f28a

Break all the things

1baf7fd

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Improve code quality

be5ddb2

Clean-up Dockerfile

9e8018b

Remove temporary variable

0c400a9

Code quality fixes

1cd5a76

Re-enable runtime validation

23c11ca

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Code quality

96c4723

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Merge branch 'features-runtime-config-yaml' of https://github.com/tom…

f9af327

…kerkhove/promitor into features-runtime-config-yaml

tomkerkhove mentioned this pull request Jul 8, 2019

Provide support for hot-swapping scraping configuration #573

Open

Inject logger

06c6954

Merge branch 'master' into features-runtime-config-yaml

9fa6b7e

tomkerkhove added 6 commits July 10, 2019 08:06

WIP

80c8b58

Merge master

34a5de8

Code cleanup

57e7ed2

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Provide very basic & ugly bogus + runtime config generator

6e3d8c4

Merge branch 'master' into features-runtime-config-yaml

abef119

Code cleanup

2755c1c

tomkerkhove added 2 commits July 22, 2019 18:48

Merge branch 'master' into features-runtime-config-yaml

b4446ab

WIP

9885ea3

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Provide more tests

9408159

tomkerkhove changed the title ~~WIP - Switch to runtime configuration YAML~~ Switch to runtime configuration YAML Jul 22, 2019

Code cleanup

f8b5d79

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

tomkerkhove added 3 commits July 22, 2019 21:30

Most specific over least specific verbosity for logging

23b322d

Add new volume mount to landing page

860d4a5

Merge branch 'master' into features-runtime-config-yaml

4367373

Fix configuration for Application Insights

69a7c86

Fix inverted flag for disabling telemetry

473a698

tomkerkhove merged commit fca5900 into master Jul 25, 2019

tomkerkhove deleted the features-runtime-config-yaml branch July 25, 2019 18:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to runtime configuration YAML #608

Switch to runtime configuration YAML #608

tomkerkhove commented Jul 7, 2019 •

edited

Loading

promitor-bot commented Jul 7, 2019

promitor-bot commented Jul 7, 2019

promitor-bot commented Jul 8, 2019

promitor-bot commented Jul 9, 2019

promitor-bot commented Jul 19, 2019

promitor-bot commented Jul 22, 2019

promitor-bot commented Jul 22, 2019

promitor-bot commented Jul 25, 2019

promitor-bot commented Jul 25, 2019

promitor-bot commented Jul 25, 2019

Switch to runtime configuration YAML #608

Switch to runtime configuration YAML #608

Conversation

tomkerkhove commented Jul 7, 2019 • edited Loading

Configuration sample

Done via new PR

promitor-bot commented Jul 7, 2019

promitor-bot commented Jul 7, 2019

promitor-bot commented Jul 8, 2019

promitor-bot commented Jul 9, 2019

promitor-bot commented Jul 19, 2019

promitor-bot commented Jul 22, 2019

promitor-bot commented Jul 22, 2019

promitor-bot commented Jul 25, 2019

promitor-bot commented Jul 25, 2019

promitor-bot commented Jul 25, 2019

tomkerkhove commented Jul 7, 2019 •

edited

Loading